chore: add precomp method (blst) #267
Draft
+188
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevaundray
commented
Sep 6, 2024
Comment on lines
+16
to
+18
| pub struct FixedBaseMSMPrecompBLST { | ||
| table: Vec<Vec<G1Affine>>, // TODO: Make this a Vec<> and then just do the maths in msm function for offsetting | ||
| // table: Vec<G1Affine>, |
There was a problem hiding this comment.
Both seem to perform the same
kevaundray
commented
Sep 6, 2024
kevaundray
commented
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off of #247 as I needed the bacth_add method
This scales better than the blst method due to batch_multi_add though I'd like to see if we can port the way blst does it over to this and then do batch_multi_add using that ported method. The blst method seems to be a lot more cache friendly